Skip to content

[Streams] Dashboard linking#204309

Merged
dgieselaar merged 149 commits intoelastic:mainfrom
dgieselaar:streams-app-asset-linking
Jan 7, 2025
Merged

[Streams] Dashboard linking#204309
dgieselaar merged 149 commits intoelastic:mainfrom
dgieselaar:streams-app-asset-linking

Conversation

@dgieselaar
Copy link
Copy Markdown
Contributor

@dgieselaar dgieselaar commented Dec 14, 2024

Links dashboard to Streams.

Changes:

simianhacker and others added 30 commits November 1, 2024 11:22
gsoldevila added a commit that referenced this pull request Jan 7, 2025
## Summary

So that it can be used from `streams_app` (o11y).
See  #204309

Steps to relocate:

1. Fetch latest `main`
2. Update the `group` and/or `visibility` in the module's manifest.
3. Run `node scripts/relocate --moveOnly
@kbn/saved-objects-tagging-plugin`
@dgieselaar dgieselaar merged commit 28414ce into elastic:main Jan 7, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12659295244

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
streamsApp 178 200 +22

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
streams 9 13 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
streamsApp 182.2KB 190.3KB +8.1KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
streams 2 8 +6
Unknown metric groups

API count

id before after diff
streams 9 13 +4

References to deprecated APIs

id before after diff
streamsApp 0 2 +2

History

@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 204309

Questions ?

Please refer to the Backport tool documentation

@dgieselaar
Copy link
Copy Markdown
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

dgieselaar added a commit to dgieselaar/kibana that referenced this pull request Jan 8, 2025
Links dashboard to Streams.

Changes:
- Introduces `IndexStorageAdapter` to manage ES indices - see
https://github.com/dgieselaar/kibana/blob/streams-app-asset-linking/x-pack/solutions/observability/packages/utils_server/es/storage/README.md
for motivation
- Introduces `AssetClient` and `AssetService` to manage asset links with
`IndexStorageAdapter`
- `RepositorySupertestClient` to make it easier to use
`@kbn/server-route-repository` with FTR tests
- refactors related to above changes

---------

Co-authored-by: Chris Cowan <chris@elastic.co>
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 28414ce)

# Conflicts:
#	.github/CODEOWNERS
#	x-pack/test/tsconfig.json
gsoldevila added a commit to gsoldevila/kibana that referenced this pull request Jan 8, 2025
## Summary

So that it can be used from `streams_app` (o11y).
See  elastic#204309

Steps to relocate:

1. Fetch latest `main`
2. Update the `group` and/or `visibility` in the module's manifest.
3. Run `node scripts/relocate --moveOnly
@kbn/saved-objects-tagging-plugin`

(cherry picked from commit a8579bb)

# Conflicts:
#	.github/CODEOWNERS
#	packages/kbn-relocate/utils/relocate.ts
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 9, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

dgieselaar added a commit that referenced this pull request Jan 10, 2025
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Streams] Dashboard linking
(#204309)](#204309)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dario
Gieselaar","email":"dario.gieselaar@elastic.co"},"sourceCommit":{"committedDate":"2025-01-07T21:04:42Z","message":"[Streams]
Dashboard linking (#204309)\n\nLinks dashboard to
Streams.\n\nChanges:\n- Introduces `IndexStorageAdapter` to manage ES
indices -
see\nhttps://github.com/dgieselaar/kibana/blob/streams-app-asset-linking/x-pack/solutions/observability/packages/utils_server/es/storage/README.md\nfor
motivation\n- Introduces `AssetClient` and `AssetService` to manage
asset links with\n`IndexStorageAdapter`\n- `RepositorySupertestClient`
to make it easier to use\n`@kbn/server-route-repository` with FTR
tests\n- refactors related to above
changes\n\n---------\n\nCo-authored-by: Chris Cowan
<chris@elastic.co>\nCo-authored-by: Joe Reuter
<johannes.reuter@elastic.co>\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"28414ce988f604f3d0ecbb6c484d3cd25ec8408b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:version","v8.18.0","Feature:Streams"],"number":204309,"url":"https://github.com/elastic/kibana/pull/204309","mergeCommit":{"message":"[Streams]
Dashboard linking (#204309)\n\nLinks dashboard to
Streams.\n\nChanges:\n- Introduces `IndexStorageAdapter` to manage ES
indices -
see\nhttps://github.com/dgieselaar/kibana/blob/streams-app-asset-linking/x-pack/solutions/observability/packages/utils_server/es/storage/README.md\nfor
motivation\n- Introduces `AssetClient` and `AssetService` to manage
asset links with\n`IndexStorageAdapter`\n- `RepositorySupertestClient`
to make it easier to use\n`@kbn/server-route-repository` with FTR
tests\n- refactors related to above
changes\n\n---------\n\nCo-authored-by: Chris Cowan
<chris@elastic.co>\nCo-authored-by: Joe Reuter
<johannes.reuter@elastic.co>\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"28414ce988f604f3d0ecbb6c484d3cd25ec8408b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204309","number":204309,"mergeCommit":{"message":"[Streams]
Dashboard linking (#204309)\n\nLinks dashboard to
Streams.\n\nChanges:\n- Introduces `IndexStorageAdapter` to manage ES
indices -
see\nhttps://github.com/dgieselaar/kibana/blob/streams-app-asset-linking/x-pack/solutions/observability/packages/utils_server/es/storage/README.md\nfor
motivation\n- Introduces `AssetClient` and `AssetService` to manage
asset links with\n`IndexStorageAdapter`\n- `RepositorySupertestClient`
to make it easier to use\n`@kbn/server-route-repository` with FTR
tests\n- refactors related to above
changes\n\n---------\n\nCo-authored-by: Chris Cowan
<chris@elastic.co>\nCo-authored-by: Joe Reuter
<johannes.reuter@elastic.co>\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"28414ce988f604f3d0ecbb6c484d3cd25ec8408b"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 10, 2025
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
## Summary

So that it can be used from `streams_app` (o11y).
See  elastic#204309

Steps to relocate:

1. Fetch latest `main`
2. Update the `group` and/or `visibility` in the module's manifest.
3. Run `node scripts/relocate --moveOnly
@kbn/saved-objects-tagging-plugin`
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
Links dashboard to Streams.

Changes:
- Introduces `IndexStorageAdapter` to manage ES indices - see
https://github.com/dgieselaar/kibana/blob/streams-app-asset-linking/x-pack/solutions/observability/packages/utils_server/es/storage/README.md
for motivation
- Introduces `AssetClient` and `AssetService` to manage asset links with
`IndexStorageAdapter`
- `RepositorySupertestClient` to make it easier to use
`@kbn/server-route-repository` with FTR tests
- refactors related to above changes

---------

Co-authored-by: Chris Cowan <chris@elastic.co>
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:Streams This is the label for the Streams Project release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.18.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants